-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensured permissions for htdocs/application/cache #2912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one typo in promiser I think
b2fd58f
to
4e628c6
Compare
handle => "cfe_internal_setup_knowledge_files_doc_root_application_cache", | ||
create => "true", | ||
depth_search => recurse_basedir("inf"), | ||
perms => mog("0660", $(def.cf_apache_user), $(def.cf_apache_group)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this promise targets both files and directories from the promised directory all the way down.
With the changes to rxdirs, you won't get execute (list) permission on directories. Is that OK or do you need to be able to list the files in the directories?
If so, then you should split this into 2 promises. One that targets files (file_select) and one that targets directories, each specifying the permissions you want for files or directories respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I don't need nested directories, only files, changed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it changes perms back
info: Owner of '/var/cfengine/httpd/htdocs/application/cache' was 0, set to 997
info: Directory '/var/cfengine/httpd/htdocs/application/cache' had permissions 0550, changed it to 0770
info: Owner of '/var/cfengine/httpd/htdocs/application/cache' was 997, set to 0
info: Directory '/var/cfengine/httpd/htdocs/application/cache' had permissions 0770, changed it to 0550
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I pushed a couple changes to your fork, give that a go. It stopped the flipping for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK if you don't need execute bit on directories, if you do then I think it needs more.
672ddc3
to
1c57883
Compare
Looks like I messed it up:
|
@cf-bottom jenkins please. |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10960/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10960/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable, squash commits yeah?
Ticket: ENT-11442 Signed-off-by: Ihor Aleksandrychiev <[email protected]>
Ticket: ENT-11442